gnome-shell crashes in meta_wayland_popup_grab_get_top_popup

[Marco Trevisan (Treviño)]

[ Impact ]

Upstream issue https://gitlab.gnome.org/GNOME/mutter/-/issues/2563 with various reproducers.

Fixed in https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2940

#9 0x00007f548a442476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#10 0x00007f548a4287f3 in __GI_abort () at ./stdlib/abort.c:79
#11 0x00007f548b70bb57 in g_assertion_message
    (domain=<optimized out>, file=<optimized out>, line=<optimized out>, func=0x7f548a9b3480 <__func__.0.lto_priv.120> "meta_wayland_popup_grab_get_top_popup", message=<optimized out>) at ../../../glib/gtestutils.c:3253
#12 0x00007f548b76570f in g_assertion_message_expr
    (domain=domain@entry=0x7f548a98d6aa "libmutter", file=file@entry=0x7f548a9b2d20 "../src/wayland/meta-wayland-popup.c", line=line@entry=233, func=func@entry=0x7f548a9b3480 <__func__.0.lto_priv.120> "meta_wayland_popup_grab_get_top_popup", expr=expr@entry=0x7f548a9b2cf8 "!wl_list_empty (&grab->all_popups)")
    at ../../../glib/gtestutils.c:3279
#13 0x00007f548a9386f0 in meta_wayland_popup_grab_get_top_popup (grab=<optimized out>)
    at ../src/wayland/meta-wayland-popup.c:233
#14 meta_wayland_popup_grab_get_top_popup (grab=0x5602a0ec8f70) at ../src/wayland/meta-wayland-popup.c:229
#15 0x00007f548a94c930 in meta_wayland_pointer_get_top_popup (pointer=<optimized out>)
    at ../src/wayland/meta-wayland-pointer.c:1348
#16 finish_popup_setup (xdg_popup=0x56029dfe48f0) at ../src/wayland/meta-wayland-xdg-shell.c:1086
#17 meta_wayland_xdg_popup_apply_state (surface_role=0x56029dfe48f0, pending=0x7f5470089630)
    at ../src/wayland/meta-wayland-xdg-shell.c:1184
#18 0x00007f548a945bc5 in meta_wayland_surface_role_apply_state
    (pending=0x7f5470089630, surface_role=<optimized out>) at ../src/wayland/meta-wayland-surface.c:1935
#19 meta_wayland_surface_apply_state (surface=<optimized out>, state=<optimized out>)
    at ../src/wayland/meta-wayland-surface.c:873
#20 0x00007f548a946fb7 in meta_wayland_surface_commit (surface=0x56029fb11a10)
    at ../src/wayland/meta-wayland-surface.c:1029
#21 wl_surface_commit (client=<optimized out>, resource=<optimized out>)
    at ../src/wayland/meta-wayland-surface.c:1187
#22 0x00007f5489f5be2e in () at /lib/x86_64-linux-gnu/libffi.so.8
#23 0x00007f5489f58493 in () at /lib/x86_64-linux-gnu/libffi.so.8
#24 0x00007f548b636260 in () at /lib/x86_64-linux-gnu/libwayland-server.so.0
#25 0x00007f548b63a474 in () at /lib/x86_64-linux-gnu/libwayland-server.so.0
#26 0x00007f548b638eea in wl_event_loop_dispatch () at /lib/x86_64-linux-gnu/libwayland-server.so.0
#27 0x00007f548a92b44b in wayland_event_source_dispatch
    (base=<optimized out>, callback=<optimized out>, data=<optimized out>) at ../src/wayland/meta-wayland.c:110
#28 0x00007f548b742d3b in g_main_dispatch (context=0x56029df478f0) at ../../../glib/gmain.c:3419
#29 g_main_context_dispatch (context=0x56029df478f0) at ../../../glib/gmain.c:4137
#30 0x00007f548b798258 in g_main_context_iterate.constprop.0
    (context=0x56029df478f0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>)
    at ../../../glib/gmain.c:4213
#31 0x00007f548b7422b3 in g_main_loop_run (loop=0x5602a05cf790) at ../../../glib/gmain.c:4413
#32 0x00007f548a8d0b69 in meta_context_run_main_loop (context=<optimized out>, error=0x7ffdd91f9ce8)
    at ../src/core/meta-context.c:437
#33 0x000056029d1fff12 in ()
#34 0x00007f548a429d90 in __libc_start_call_main
     (main=main@entry=0x56029d1ffa70, argc=argc@entry=1, argv=argv@entry=0x7ffdd91f9e88)
    at ../sysdeps/nptl/libc_start_call_main.h:58
#35 0x00007f548a429e40 in __libc_start_main_impl
     (main=0x56029d1ffa70, argc=1, argv=0x7ffdd91f9e88, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffdd91f9e78) at ../csu/libc-start.c:392
#36 0x000056029d2001b5 in ()

[ Test case ]

- Install gnome-console
- Run and maximize it
- Move the cursor all the way to the left and right clicking in two different locations.
- GNOME SHell should not crash

[ Regression potentials ]

Popup menus may not be properly placed on screen.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: gnome-shell 42.9-0ubuntu2
Uname: Linux 6.8.7-zabbly+ x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: ubuntu:GNOME
Date: Tue May 7 15:42:35 2024
DisplayManager: gdm3
InstallationDate: Installed on 2010-07-10 (5050 days ago)
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
RelatedPackageVersions: mutter-common 42.9-0ubuntu7
SourcePackage: gnome-shell
UpgradeStatus: Upgraded to jammy on 2020-06-14 (1422 days ago)

[Steve Langasek (vorlon)]

Hello Marco, or anyone else affected,

Accepted mutter into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mutter/42.9-0ubuntu8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.